[Bugfix] Fix cache maximum size settings not working properly with pluggable caching #16636
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16636 +/- ##
============================================
- Coverage 72.15% 72.08% -0.08%
- Complexity 65145 65162 +17
============================================
Files 5315 5318 +3
Lines 303573 303833 +260
Branches 43925 43962 +37
============================================
- Hits 219039 219003 -36
- Misses 66587 66925 +338
+ Partials 17947 17905 -42 ☔ View full report in Codecov by Sentry. |
|
❌ Gradle check result for 469006a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
force-pushed
the
cache-impl-size-setting-bugfix
branch
from
469006a to
76ad2ef
Compare
|
❌ Gradle check result for 76ad2ef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
|
❌ Gradle check result for c75fb9f: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Fixes a bug (#16631) where max size settings for cache implementations were not working correctly when pluggable caching is on.
The cache implementations like OpenSearchOnHeapCache had been changed so that the max size value from the config overrode the value from their setting. This allowed the TieredSpilloverCache to send different sizes into the cache config when constructing its segments. However, the IndicesRequestCache was also putting its default 1% of heap size value into the cache config, and this overrode the setting values even when pluggable caching was on.
Fixes this by having the IRC only put a max size value into the config if pluggable caching is off.
Adds UTs around this. Also tested manually with different combinations of settings.
Related Issues
Resolves #16631
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.